Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 750 #751

Merged
merged 8 commits into from
Jan 6, 2022
Merged

Fix 750 #751

merged 8 commits into from
Jan 6, 2022

Conversation

aviv1ron1
Copy link
Contributor

@aviv1ron1 aviv1ron1 commented Dec 12, 2021

adds Machine ID to mappings in aql fields and
to stix: mapped to x-oca-asset hostname
from stix: mapped to x-oca-asset hostname
Closes #750

@delliott90
Copy link
Collaborator

@aviv1ron1 can you confirm that these changes will still work with just the Windows and Sysmon QRadar extensions, or will this introduce new QRadar requirements?

@aviv1ron1
Copy link
Contributor Author

@delliott90 yes - this is aligned to the latest version of the IBM QRadar Custom Properties for Microsoft Windows version 1.1.7 which introduces the Machine ID property which maps the hostname.
As long as the QRadar has this content pack updated it will work.

@aviv1ron1
Copy link
Contributor Author

@delliott90 but I see there are errors in some tests, let me fix those first.

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #751 (36f1458) into develop (36af28a) will increase coverage by 0.03%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #751      +/-   ##
===========================================
+ Coverage    63.34%   63.38%   +0.03%     
===========================================
  Files          425      425              
  Lines        36868    36878      +10     
===========================================
+ Hits         23353    23374      +21     
+ Misses       13515    13504      -11     
Impacted Files Coverage Δ
...tests/stix_translation/test_qradar_json_to_stix.py 69.62% <88.00%> (+2.22%) ⬆️
...ar_stix_to_aql/test_qradar_events_stix_to_query.py 94.13% <100.00%> (ø)
..._aql/test_qradar_perf_test_events_stix_to_query.py 94.38% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36af28a...36f1458. Read the comment docs.

@aviv1ron1
Copy link
Contributor Author

@delliott90 This is ready for merging

@delliott90
Copy link
Collaborator

Looks good, I think I'll open a PR to update the QRadar readme to be explicit on what versions of the extensions are required.

@delliott90 delliott90 merged commit 319f718 into opencybersecurityalliance:develop Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qradar module does not translate host name and IP in some cases
2 participants