-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 750 #751
Fix 750 #751
Conversation
@aviv1ron1 can you confirm that these changes will still work with just the Windows and Sysmon QRadar extensions, or will this introduce new QRadar requirements? |
@delliott90 yes - this is aligned to the latest version of the |
@delliott90 but I see there are errors in some tests, let me fix those first. |
Codecov Report
@@ Coverage Diff @@
## develop #751 +/- ##
===========================================
+ Coverage 63.34% 63.38% +0.03%
===========================================
Files 425 425
Lines 36868 36878 +10
===========================================
+ Hits 23353 23374 +21
+ Misses 13515 13504 -11
Continue to review full report at Codecov.
|
@delliott90 This is ready for merging |
Looks good, I think I'll open a PR to update the QRadar readme to be explicit on what versions of the extensions are required. |
adds
Machine ID
to mappings in aql fields andto stix: mapped to
x-oca-asset
hostname
from stix: mapped to
x-oca-asset
hostname
Closes #750