-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check existing semantic tags defined on channel types #12262
Comments
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
@kaikreuzer / I believe we should moderate the fourth rule because for old bindings you have sometimes Number channels without any dimension but the semantic tags "Measurement" + "something" make sense (I guess the binding was created before UoM was introduced in openHAB core, or maybe the developer decided to not use UoM). |
For the sonyprojector binding, I defined the channel type "powerstate" (Current detailed power state of the projector). I tagged the channel type with "Status" + "Power". It does not respect the third rule. @kaikreuzer : should I switch to "Measurement" + "Power" ? Or maybe only "Status" ? |
@kaikreuzer : for the sagercaster binding, we have 2 cases to discuss:
@clinioque as author of the binding |
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
You could add some SAT checks so it is easier to check and enforce the logic on tags. 😉 |
Related to #12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to #12262 Signed-off-by: Laurent Garnier <[email protected]>
Thanks @lolodomo for your efforts here, the summary above sounds good to me. I'll try to look into and answer your questions later today... |
Yes, of course. And that is clear for me that is the current and temporary proposed guidelines, not the final ones. |
Related to #12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to #12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to #12262 Signed-off-by: Laurent Garnier <[email protected]>
Or maybe even user docs? After all, deriving consistent default tags should have user impact, otherwise there would be no point. So if we could explain the rules in relation to the end result, this might be worth doing. |
To add a questions to the 'rules' discussion i want to point to #14160 Some tags where added (Setpoint + Temperature) to the "Intended Boiler Temperature" channel. While this channel is read-only, it does hold the setpoint for that temperature. It is not writable from openHAB, but it is controlled by the device. So how would this channel be tagged? If Setpoint+Temperature is wrong, then should the rules be adapted to never ever allow control + read-only? I hardly see any bindings with default tags, and that might be because these rules are not clear yet. I really think the out-of-the-box experience could be improved by adding as much as tags as possible (offcourse only by rules and that make sense). I'm willing to spend a lot of time on many bindings to add those tags, but only if we cvan come up with some more rules / guidance. |
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Follow-up openhab#12269 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
* [deconz] Cleanup semantic tags Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
…b#12750) dynamically Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#12262 Signed-off-by: Laurent Garnier <[email protected]>
This issue has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/setting-semantic-class-from-binding/146975/4 |
This issue has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-5-semantic-model-proposal/162526/88 |
How should I set the tags for an airconditioner mode channel? Ditto for:
|
The guidelines about semantic tags are not yet really clear.
We found the following temporary agreement with @kaikreuzer to start adding semantic tags. Here are the current guidelines. Kai, please correct me if something is wrong or not enough clear:
Now here are all the bindings which defined semantic tags on static channel types. We have to check if they respect the rules defined above:
And here are all the bindings using
withDefaultTags
(channel) and/orwithTags
/withTag
(channel type) that should be checked:We can discuss in this topic each time we find a tag which does not match the rules.
The text was updated successfully, but these errors were encountered: