Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap interpolation parameter for charts #4610

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mherwege
Copy link
Contributor

Closes #3662

This introduces an extra parameter for sitemap charts, interpolation, that can take two possible values: linear or step. If not set, the current behaviour will be used (step for OnOff or OpenClosed and linear for all other values).

Also fixes an issue where the yAxisDecimalPattern was not considered for managed sitemaps.

@mherwege mherwege requested a review from a team as a code owner February 18, 2025 16:30
@mherwege mherwege marked this pull request as draft February 18, 2025 16:45
Signed-off-by: Mark Herwege <[email protected]>
@mherwege mherwege marked this pull request as ready for review February 18, 2025 16:49
@mherwege mherwege changed the title Stemap interpolation parameter for charts Sitemap interpolation parameter for charts Feb 18, 2025
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

@mherwege : did you see that issue?
openhab/openhab-webui#3025 (comment)

@mherwege
Copy link
Contributor Author

@mherwege : did you see that issue? openhab/openhab-webui#3025 (comment)

I saw it a while ago, but didn't see the issue in core code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Horizontal Connecting Lines in Charts for Persistence Strategy everyChange
2 participants