OAuth RFC-8628 Device Code Grant Flow (deadline 2025-03-15) #4632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
|
@mherwege @jlaur .. apropos openhab/openhab-addons#18354 |
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
|
@mherwege / @jlaur see my comment/question here openhab/openhab-addons#18354 (comment) |
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
|
Just to confirm that this is ready for review. |
andrewfg
changed the title
|
@kritsel many thanks for pointing out the need for this. |
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
|
PS I am working on some tweaks to respond to server error responses.. |
add support for response error exception, support slow down, fix log texts, throw fewer exceptions Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
|
@openhab/add-ons-maintainers in case you need evidence of successful testing .. please see work flow below.. 1. Thing offline: click link to servlet
2. Servlet: click link to authentication URL
3. Enter User Id
3. Enter credentials
4. Credentials confirmed
5. Thing online
|
lsiepel
suggested changes
Mar 12, 2025
...2client/src/main/java/org/openhab/core/auth/oauth2client/internal/OAuthConnectorRFC8628.java
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <[email protected]>
lsiepel
approved these changes
Mar 12, 2025
andrewfg
changed the title
andrewfg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds RFC-8628 Device Code Grant Flow support to the OH Core OAuth service.
Specifically it adds new RFC-8628 specific classes and extends the functionality of already existing OAuth services to add support for the new RFC-8628 Device Code Grant Flow functionality.
This PR is required by openhab/openhab-addons#18354 -- which has an implementation deadline of March 15th 2025.
Signed-off-by: Andrew Fiddian-Green [email protected]