Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade app dependencies to match core #1722

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

holgerfriedrich
Copy link
Member

Adapt demo app to core change openhab/openhab-core#4584

@holgerfriedrich holgerfriedrich marked this pull request as ready for review February 2, 2025 13:25
@holgerfriedrich holgerfriedrich requested a review from a team as a code owner February 2, 2025 13:25
@holgerfriedrich holgerfriedrich added the awaiting other PR Depends on another PR label Feb 2, 2025
@holgerfriedrich
Copy link
Member Author

PR in core is merged, this one could be merged as well. The changes are only affecting app, this is why CI is fine even before we have a new core build from Jenkins.

@wborn wborn merged commit acf611c into openhab:main Feb 15, 2025
2 checks passed
@wborn wborn added this to the 5.0 milestone Feb 15, 2025
@holgerfriedrich holgerfriedrich deleted the pr-upgrades branch February 15, 2025 10:37
@mstormi
Copy link
Contributor

mstormi commented Feb 15, 2025

Are you sure that all of these dependency updates apply to core changes that were introduced AFTER OH4?

I'm experiencing trouble with bundles not becoming active in latest release (4.3.2) and I'm not the only one. This started to happen after updating to 4.3-something. 4.2 was still fine it seems.

What about Shelly libraries?
Given the low number of bindings on those instances I'm seeing the problem with, they sound like a prime suspect.
@holgerfriedrich could you please have a look at the linked issue if it's linked to your depency updates ?
If so we might need a backport to 4.3. Makes sense anyway, no? Probably the easiest way to test if that helps with the mentioned issue.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants