7903933: Move sharable items from different generations to a common file #278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this patch to move the
C_*
layouts and the static utility methods into separate classes:LayoutUtils.java
andFFMUtils.java
, respectively.-t
option is no used and the files are generated into the default package, in that case we use the classname to call the static methods or use theC_*
constants.Some tests had to be modified slightly, either by adding new static imports or replacing classnames.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/278/head:pull/278
$ git checkout pull/278
Update a local copy of the PR:
$ git checkout pull/278
$ git pull https://git.openjdk.org/jextract.git pull/278/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 278
View PR using the GUI difftool:
$ git pr show -t 278
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/278.diff
Using Webrev
Link to Webrev Comment