luci: Make password reveal work with password managers #7479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a possible patch for #7478 |
systemcrash
changed the title
systemcrash
reviewed
Jan 9, 2025
|
Drop the merge commit. Rebase. Squash commits. |
andrewdodd
force-pushed
the
bugfix-7478
branch
from
e7de5e9 to
593d777
Compare
|
Make sure to rebase as other changes in master are conflicting. |
andrewdodd
force-pushed
the
bugfix-7478
branch
from
593d777 to
f294ee0
Compare
|
I had a look at the test build, but the log is so long I can't really find where to look for clues ("error"; "failure" and "failed" appear too much to use them to find the failure). Is there something I should try here? |
andrewdodd
force-pushed
the
bugfix-7478
branch
from
3339250 to
fff9b22
Compare
|
@systemcrash , sorry to hassle, but I'm not sure if there is something I should do next, could you please let me know? |
Password managers (like LastPass etc) tend to add additional elements into the DOM for their own context menus. If this happens between the hide/reveal button and the password input, then the logic to reveal the password breaks. This change updates the onclick handler to look backward in the DOM for the first sibling that is an input, and to then toggle the password/text type on that element. This change deliberately only updates the main ui.js file, not any application files. Signed-off-by: Andrew Dodd <[email protected]>
andrewdodd
force-pushed
the
bugfix-7478
branch
from
fff9b22 to
e11550b
Compare
|
I removed the change to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Password managers (like LastPass etc) tend to add additional elements into the DOM for their own context menus. If this happens between the hide/reveal button and the password input, then the logic to reveal the password breaks.
This change updates the onclick handler to look backward in the DOM for the first sibling that is an input, and to then toggle the password/text type on that element.
Signed-off-by: <[email protected]>row (viagit commit --signoff)<package name>: titlefirst line subject for packagesPKG_VERSIONin the Makefile