Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better OCI compatibility #142

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

jonesbusy
Copy link
Collaborator

Fix #141

Testing done

Automated

Tested with ORAS and test java cli

CLI Go

{
    "annotations": {
        "org.opencontainers.image.created": "2025-02-23T09:50:04Z"
    },
    "artifactType": "application/vnd.unknown.artifact.v1",
    "config": {
        "data": "e30=",
        "digest": "sha256:44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a",
        "mediaType": "application/vnd.oci.empty.v1+json",
        "size": 2
    },
    "layers": [
        {
            "annotations": {
                "org.opencontainers.image.title": "hello.txt"
            },
            "digest": "sha256:7d865e959b2466918c9863afca942d0fb89d7c9ac0c99bafc3749504ded97730",
            "mediaType": "application/vnd.oci.image.layer.v1.tar",
            "size": 4
        }
    ],
    "mediaType": "application/vnd.oci.image.manifest.v1+json",
    "schemaVersion": 2
}

Java

{
    "annotations": {
        "org.opencontainers.image.created": "2025-02-23T09:50:04Z"
    },
    "artifactType": "application/vnd.unknown.artifact.v1",
    "config": {
        "data": "e30=",
        "digest": "sha256:44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a",
        "mediaType": "application/vnd.oci.empty.v1+json",
        "size": 2
    },
    "layers": [
        {
            "annotations": {
                "org.opencontainers.image.title": "hello.txt"
            },
            "digest": "sha256:7d865e959b2466918c9863afca942d0fb89d7c9ac0c99bafc3749504ded97730",
            "mediaType": "application/vnd.oci.image.layer.v1.tar",
            "size": 4
        }
    ],
    "mediaType": "application/vnd.oci.image.manifest.v1+json",
    "schemaVersion": 2
}

Except the date, the rest is similar

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

@jonesbusy jonesbusy added the enhancement New feature or request label Feb 23, 2025
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.73%. Comparing base (f1c8c3d) to head (f746747).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/main/java/land/oras/Config.java 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #142      +/-   ##
============================================
+ Coverage     80.99%   81.73%   +0.74%     
- Complexity      224      225       +1     
============================================
  Files            19       20       +1     
  Lines           884      887       +3     
  Branches         93       93              
============================================
+ Hits            716      725       +9     
+ Misses          114      109       -5     
+ Partials         54       53       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonesbusy
Copy link
Collaborator Author

Still missing io.deis.oras.content.digest

See https://github.com/search?q=org%3Aoras-project%20%22io.deis.oras.content.digest%22&type=code

Will do an other PR related to directory compression

Signed-off-by: Valentin Delaye <[email protected]>
@jonesbusy jonesbusy force-pushed the bugfix/default-artifact-type branch from a80e5ea to f746747 Compare February 23, 2025 10:00
@jonesbusy jonesbusy merged commit a9fc8b6 into oras-project:main Feb 23, 2025
4 checks passed
@jonesbusy jonesbusy deleted the bugfix/default-artifact-type branch February 23, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difference in manifest for directory push
1 participant