Switch github workflows to ubuntu 22.04 #4607
Conversation
github is dropping support for 20.04 on 4/1/2025 so move to the next stable version. Also, back in commit e8ae7e7 we removed use of ubuntu-latest because it can change unexpectedly. Some other uses crept back in, so this changes those to use 22.04 as well.
We want to use a stable version of ubuntu, not ubuntu-latest which can change unexpectedly. This switches all the other (non-test) workflows to use ubuntu-22.04
bcl
requested review from
mvo5,
thozza,
schuellerf and
ondrejbudai
and removed request for
a team
There was a problem hiding this comment.
A bit of a meta-question (I guess its not very relevant for this PR but I'm curious): why do we pick ubuntu-22.04 instead of ubuntu-24.04 as the "stable" relase? AIUI ubuntu-latest points to ubuntu-24.04 since a few weeks [0].
The change itself looks fine and can be merged of course.
[0] actions/runner-images#10636
|
Ah, didn't realize latest was already on 24 (I pay almost zero attention to ubuntu releases), but I picked 22.04 out of the hat :) It's the next stable release after 20.04 according to github's list in the email I got. We can also jump to 24.04 if we want. |
No strong preference here, I was just curious about the choice. |
|
Why not use "latest"? Do we have a reason to pin to a specific version? |
Generally, we pin things in CI to keep it stable and know the reason for a potential failure. If the underlying infra changes automatically and causes the CI to fail, you may wonder if it is related to the PR. And when we update things related to CI infrastructure, we can be sure that the failure is related to that change. |
|
@thozza I'm not sure if I get the "pin things in CI" thing with |
That just pulls in repo metadata so we can Dependency version changes during an LTS release is unlikely to cause issues (though not impossible). The distro release changing from under your feet however can bring much larger package changes (major versions, even package names can change). |
|
The original thoughts on this are in commit e8ae7e7 and I read that as trying to keep it from jumping to a new version of the os, not pinning every last package. |
Changes the github workflows to use ubuntu-22.04 everywhere.