Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CI/CH codes implementation compatible with international operational points #6194

Closed
axrolld opened this issue Dec 21, 2023 · 0 comments
Closed

Make CI/CH codes implementation compatible with international operational points #6194

axrolld opened this issue Dec 21, 2023 · 0 comments
Labels
kind:enhancement Improvement of existing features

Comments

@axrolld
Copy link
Contributor

axrolld commented Dec 21, 2023

Description and goal

#6180 started to hardcode assumptions about CH codes, which is pretty much documented nowhere on the internet. Can't we delay this a little bit, and take the time to make an internationally acceptable list of place types? I'm pretty sure I've seen one in UIC documentation.

The plan would then be as follows:

get or make a list of operational point types
add it to the data model and documentation
during import, convert CH codes into this enum's equivalent

Acceptance criteria

TBD
@axrolld axrolld added the kind:enhancement Improvement of existing features label Dec 21, 2023
@axrolld axrolld changed the title Make CI/CH codes implementation more international Make CI/CH codes implementation compatible with international operational points Dec 21, 2023
@axrolld axrolld mentioned this issue Dec 21, 2023
Merged
@axrolld axrolld closed this as completed Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:enhancement Improvement of existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@axrolld