Add CI/CH/UIC codes next to station names

[Yohh]

editoast:

• add uic and ch to PathfindingResponse and PathWaypoint struct
• get them from waypoint in Pathfinding impl
• add ch to ResultStops struct, add_stops_additional_information fn and train_with_simulation_output_fixture_set fn
• update openapi.yaml

front:

• create formatUicToCi in utils/strings.ts
• add CI/CH codes in ModalSugerredVias, StationCard and DisplayVias
• add CH code in AllowancesModalOP and DriverTrainScheduleStop
• add elipsis to vias name in modal
• replace suggered by suggested

[codecov]

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (ee0649e) 26.66% compared to head (c7e60ec) 26.67%.
Report is 1 commits behind head on dev.

Files	Patch %	Lines
...anageTrainSchedule/Itinerary/ModalSuggeredVias.tsx	0.00%	31 Missing ⚠️
...ents/ManageTrainSchedule/Itinerary/DisplayVias.tsx	0.00%	5 Missing ⚠️
front/src/common/StationCard.tsx	0.00%	4 Missing ⚠️
...ts/DriverTrainSchedule/DriverTrainScheduleStop.tsx	0.00%	4 Missing ⚠️
...nageTrainSchedule/Allowances/AllowancesModalOP.tsx	0.00%	4 Missing ⚠️
front/src/utils/strings.ts	80.00%	2 Missing ⚠️
...oast/src/views/train_schedule/simulation_report.rs	50.00%	1 Missing ⚠️
...portTrainSchedule/generateTrainSchedulesPayload.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #6180      +/-   ##
============================================
+ Coverage     26.66%   26.67%   +0.01%     
  Complexity     2139     2139              
============================================
  Files           931      931              
  Lines        123397   123444      +47     
  Branches       2682     2682              
============================================
+ Hits          32901    32927      +26     
- Misses        88898    88919      +21     
  Partials       1598     1598              

Flag	Coverage Δ
core	78.87% <ø> (ø)
editoast	74.95% <94.73%> (+<0.01%)	⬆️
front	9.38% <23.88%> (+0.01%)	⬆️
gateway	2.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[multun]

I understand this is the easier way to implement it, but ch codes aren't something international. Couldn't we use an enum of common location specifiers ? I believe the UIC has a list of CH equivalents

[axrolld]

@multun didn't we agree on implementing this that way for now and think about a more international-friendly model later ? We were already displaying those info in the search results, this PR is just supposed to spread this infos.

I agree that it is not the target but this is a quick improvement.

[multun]

I don't think we did agree: this change starts to hardcode assumptions about CH codes, which is pretty much documented nowhere on the internet. Can't we delay this a little bit, and take the time to make an internationally acceptable list of place types? I'm pretty sure I've seen one in UIC documentation.

The plan would then be as follows:

• get or make a list of operational point types
• add it to the data model and documentation
• during import, convert CH codes into this enum's equivalent

[woshilapin]

A few minor comments (some stylistic, some about factorizing code). But nothing blocking from merging.

[leovalais]

LGTM (peer reviewed), one small fix I've missed:

[Math-R]

LGTM :)

[axrolld]

The plan would then be as follows:

• get or make a list of operational point types
• add it to the data model and documentation
• during import, convert CH codes into this enum's equivalent

This plan should be kept in mind for later, but once again this task was to spread those info quickly to acess them in front end. We know it's not the target. It's a quick unperfect improvement.
Are you ok if i open a new issue to make an internationally acceptable list of place types ? This can easily be done later.

[multun]

sure. I'm worried I'll be one more thing on a list of hacks we don't process as fast as we create.

[flomonster]

The purpose of this PR is to add context to the OPs. For the moment, we haven't generalized the trigram and CH code system. But this can be done later. During a side discussion, we agreed to carry out this task. However, it's important to ensure that the services work properly when the SNCF extension is not filled in.

[Yohh]

with german infra, CH and CI are null, everything works fine
@flomonster is it ok for you?

[axrolld]

I created this issue to keep track of the leftover work. Feel free to add some details to it !

[clarani]

Left some comments :)

[clarani]

LGTM ✅ I didn't test but I believe the previous reviewers did it :)