Prevent LMDB related segfault for #2755 #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make transactions no-op if the file handle is invalid
|
While it's a good idea to avoid conditions that result in a segfault, alternatives that result in failing silently are pretty disadvantageous too. I'll have a closer look. What we might wind up doing is merging something close to what you have here, and then I can add some additional content on top of it. |
|
I'll go ahead and merge this. Some further improvements, including to make the failure non-silent, can be made later. Thanks for the contribution @dvershinin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make transactions no-op if the file handle is invalid (due to permissions, or other reasons like lmdb library mismatch).