Use pkg-config to find libxml2, falling back to xml2-config if necessary #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debian is taking steps to remove xml2-config in favour of pkg-config. This means ModSecurity will build without libxml2 support by default on Debian, Ubuntu and other distributions tracking Debian packages. This patch modifies build/find_xml.m4 to check for libxml2 via pkg-config, falling back to xml2-config if necessary.
|
Here you go, @martinhsv. |
|
Merged. Thanks @hughmcmaster . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian is taking steps to remove
xml2-configin favour ofpkg-config. This means ModSecurity will build withoutlibxml2support by default on Debian, Ubuntu and other distributions tracking Debian packages.This patch modifies
build/libxml.m4to check forlibxml2viapkg-config, falling back toxml2-configif necessary.Patch for ModSecurity v2, as discussed in #2714.