Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Everest-1862 | topology diagram view #1088

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

fabio-silva
Copy link
Collaborator

@fabio-silva fabio-silva commented Feb 6, 2025

EVEREST-1862 Powered by Pull Request Badge

Screenshot 2025-02-04 at 18 36 09

@fabio-silva fabio-silva requested a review from a team as a code owner February 6, 2025 16:53
@dianabirs
Copy link
Contributor

The zoom icons are not visible in dark mode
image

@dianabirs
Copy link
Contributor

@fabio-silva I have a suggestion here:

Because only the grab cursor is displayed inside the topology diagram, it makes it impossible for a user to copy a component's name. Could we change this that the cursor is changed to arrow when hovering the name of the component? I think a user should be able to copy that name for debugging purposes

@fabio-silva
Copy link
Collaborator Author

@fabio-silva I have a suggestion here:

Because only the grab cursor is displayed inside the topology diagram, it makes it impossible for a user to copy a component's name. Could we change this that the cursor is changed to arrow when hovering the name of the component? I think a user should be able to copy that name for debugging purposes

That's a valid point. However, it seems like it's not plain simple as changing the cursor type. The text remains unselectable even with the cursor. I imagine react-flow manages events in the diagram for dragging purposes, which makes this more difficult without probably having to mess with CSS and events.
TBH, I wouldn't change this for now. I added the "cursor" pointer to component nodes so that users know they are selectable anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants