Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go version to 1.18 #32874

Closed
purelind opened this issue Mar 7, 2022 · 4 comments · Fixed by #33350
Closed

Upgrade go version to 1.18 #32874

purelind opened this issue Mar 7, 2022 · 4 comments · Fixed by #33350
Assignees
@hawkingrei
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@purelind
Copy link
Contributor

purelind commented Mar 7, 2022

Enhancement

Upgrade go version to 1.18
@purelind purelind added the type/enhancement The issue or PR belongs to an enhancement. label Mar 7, 2022
@bb7133
Copy link
Member

bb7133 commented Mar 10, 2022

PTAL @hawkingrei

@rleungx
Copy link
Member

rleungx commented Mar 10, 2022

There are several issues when using golangci-lint with 1.18. More compatibility issues can be found in golangci/golangci-lint#2438

@hawkingrei
Copy link
Member

There are several issues when using golangci-lint with 1.18. More compatibility issues can be found in golangci/golangci-lint#2438

You can update the image except for linter.

@purelind purelind mentioned this issue Mar 10, 2022
Merged
@nolouch nolouch mentioned this issue Mar 11, 2022
Merged
@hawkingrei hawkingrei mentioned this issue Mar 14, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Mar 17, 2022
@hawkingrei
gomod: update dependency for golang1.18 (#33053)
6b2e37f 
ref #32874
@purelind
Copy link
Contributor Author

ci pipeline on master branch has upgrade go version from go1.16 go go1.18.

@hawkingrei hawkingrei mentioned this issue Mar 23, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Mar 23, 2022
@hawkingrei
*: update go1.18 for github action job (#33350)
6d01855 
close #32874
yahonda added a commit to yahonda/tidb-dev-guide that referenced this issue Mar 28, 2022
@yahonda
Bump go versiom from 1.16 to 1.18
c3bc852 
Follow up pingcap/tidb#32874
yahonda added a commit to yahonda/tidb-dev-guide that referenced this issue Mar 28, 2022
@yahonda
Bump go version from 1.16 to 1.18
4cf13d4 
Follow up pingcap/tidb#32874
@yahonda yahonda mentioned this issue Mar 28, 2022
Merged
yahonda added a commit to yahonda/tidb-dev-guide that referenced this issue Mar 28, 2022
@yahonda
Bump go version from 1.16 to 1.18
207f022 
Follow up pingcap/tidb#32874
zhangyangyu pushed a commit to pingcap/tidb-dev-guide that referenced this issue Mar 28, 2022
@yahonda
Bump go version from 1.16 to 1.18 (#200)
f6b15f7 
Follow up pingcap/tidb#32874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hawkingrei hawkingrei

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: update go1.18 for github action job hawkingrei/tidb
4 participants
@bb7133 @hawkingrei @purelind @rleungx