Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8890] openj9 module layer binding #8976

Merged

Conversation

smilu97
Copy link
Contributor

@smilu97 smilu97 commented Jun 24, 2022

Reverted InternalModule.defineModule because it is basically an exploitative method to use Module.defineModule. Instead, ModuleBuilder.defineModule itself builds a new module-layer for its own.

ModuleBuilder.defineModule logs information about module descriptor when it fails to find the target module from the module-layer.

@smilu97 smilu97 requested a review from emeroad June 24, 2022 09:41
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #8976 (ba7cb14) into master (ffe9556) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8976      +/-   ##
============================================
- Coverage     39.84%   39.82%   -0.02%     
+ Complexity    11841    11836       -5     
============================================
  Files          3353     3353              
  Lines         91140    91140              
  Branches      10094    10094              
============================================
- Hits          36311    36297      -14     
- Misses        51724    51739      +15     
+ Partials       3105     3104       -1     
Impacted Files Coverage Δ
...p/pinpoint/rpc/client/WriteFailFutureListener.java 56.25% <0.00%> (-25.00%) ⬇️
...rp/pinpoint/rpc/packet/ControlHandshakePacket.java 44.82% <0.00%> (-24.14%) ⬇️
...pc/server/LoggingServerMessageListenerFactory.java 80.95% <0.00%> (-9.53%) ⬇️
.../navercorp/pinpoint/rpc/client/RequestManager.java 66.66% <0.00%> (-7.58%) ⬇️
...vercorp/pinpoint/rpc/packet/ClientClosePacket.java 46.66% <0.00%> (-6.67%) ⬇️
...java/com/navercorp/pinpoint/rpc/DefaultFuture.java 74.31% <0.00%> (-1.84%) ⬇️
...pinpoint/profiler/monitor/DeadlockMonitorTask.java 20.45% <0.00%> (-1.14%) ⬇️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 79.83% <0.00%> (ø)
...point/rpc/client/DefaultPinpointClientHandler.java 71.83% <0.00%> (+1.40%) ⬆️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 75.92% <0.00%> (+3.70%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffe9556...ba7cb14. Read the comment docs.

@smilu97 smilu97 force-pushed the #8890_openj9_module_layer_binding branch 3 times, most recently from b7f2cfe to 958c54f Compare June 24, 2022 10:40
@smilu97 smilu97 changed the title #8890 openj9 module layer binding [#8890] openj9 module layer binding Jun 24, 2022
@smilu97 smilu97 force-pushed the #8890_openj9_module_layer_binding branch from 958c54f to ba7cb14 Compare June 24, 2022 10:57
@smilu97 smilu97 merged commit b69d235 into pinpoint-apm:master Jun 24, 2022
@smilu97 smilu97 deleted the #8890_openj9_module_layer_binding branch June 24, 2022 11:18
@smilu97 smilu97 restored the #8890_openj9_module_layer_binding branch June 24, 2022 11:18
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
@smilu97 smilu97 deleted the #8890_openj9_module_layer_binding branch February 15, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment