Edit digital ocean port range and ordering to suppress diff #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change port range from keyword "all" to "1-65535", which is the same but with digitalocean provider 0.1.3 doesn't produce a diff * Rearrange egress firewall rules to order the Digtial Ocean API and provider returns. In current testing, this fixes the last diff that was present on `terraform plan`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same but with digitalocean provider 0.1.3 doesn't produce a diff
and provider returns. In current testing, this fixes the last diff
that was present on
terraform plan.With
digitaloceanprovider 0.1.3 and the module at this commit,terraform planseems to show no diff. This could change in future as it relies on some ordering and conventions on the Digital Ocean API side, but it should fix #3.Note: Its odd to specify ports for ICMP, but it seems to be the only way to satisfy the Terraform provider, which doesn't understand ICMP concepts. The Digital Ocean API just ignores the ICMP port value, correctly.