-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respect map.annotation string #307
fix: respect map.annotation string #307
Conversation
618cb7d
to
d7ac29d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me.
There's a unit test for lib/mapFile.js
here that needs fixing since the function signature changed:
Line 76 in 745ad2c
t.is(getMapfile(p.input), p.want) |
Also, an integration test using map.annotation
would be great, although not required.
@RyanZim I've fixed up the unit tests to take the correct objects. I've also added an extra case to show what happens when Happy to add extra integration tests if you feel them necessary. Could you please point to where I might add them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Released in 7.1.0 🎉 |
As per the PostCSS docs on sourcemaps the
opts.map.annotation
option can be set to a string, to write a manually named sourcemap file:This PR fixes PostCSS-cli to acknowledge this option, and refactors
getMapfile
to returnopts.map.annotation
if the option is set to a string.