Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where messages without text property are shown as undefined [plugin-name] #46

Merged
merged 2 commits into from
Dec 30, 2018
Merged

Fix an issue where messages without text property are shown as undefined [plugin-name] #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a72794c
Add a test to format messages without text property
nodaguti Oct 19, 2018
35d50d0
Exclude messages that don't have text property
nodaguti Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/formatter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ module.exports = function(opts) {
var positionless = options.positionless || 'first';

return function(input) {
var messages = input.messages;
var messages = input.messages.filter(function(message) {
return typeof message.text === 'string';
});
var source = input.source;

if (!messages.length) return '';
Expand Down
27 changes: 27 additions & 0 deletions test/formatter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,3 +256,30 @@ test('defaultFormatter with real sourcemaps', function(t) {
);
t.end();
});

var textlessMessages = [
{
type: 'warning',
plugin: 'foo',
},
{
type: 'dependency',
plugin: 'bar',
file: 'bar file',
},
];

var textlessMessagesOutput = '';

test('defaultFormatter with messages without text property', function(t) {
t.equal(
stripColor(defaultFormatter({
messages: textlessMessages,
source: '<input css 1>',
})),
textlessMessagesOutput,
'basic'
);

t.end();
});