Fix dbnav time zone bug #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A nice example for a transfer as a starting leg is this: Thanks for your work! (And one strike for cspell :D) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #24
In theory, this introduces a new bug if a delay reaches across the transition from standard time to daylight saving time and vice versa (which is far less tragic than the current situation imao). That's why I decided to test for diverging time zones only in the scenarios where this bug could happen as far as we currently know (only
dbnav; first or last leg; walk or transfer) instead of performing the checks somewhere inparseJourneyLeg(). I wasn't able to find this bug for transfers in the wild (yet?) as those function kind of rarely as starting or ending legs, but i guess there is a chance that this bug exists here, too.