Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(journeys): return stringifyable object #102

Closed
wants to merge 18 commits into from
Closed

fix(journeys): return stringifyable object #102

wants to merge 18 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 6, 2019

Previously, an array with additional attributes earlierRef and laterRef was returned. When stringified, the attributes were missing.

derhuerst added 17 commits January 7, 2019 16:24
@derhuerst
parseLocation: strip leading zeros from IDs 💥
9c02f5c
@derhuerst
parseDateTime: return ISO str/timestamp 💥
77e6c1c
@derhuerst
parseDateTime: parse timezone offset if given 💥
e59a08e
@derhuerst
require Node >=8.3.0 💥 💚
59781d3
@derhuerst
tests: co/yield -> async/await
b93191b
@derhuerst
movement.nextStops -> movement.nextStopovers 💥
c689688
@derhuerst
rename station(id) -> stop(id) 💥
ac3e884
@derhuerst
adapt docs & examples to 94fb64d 📝
ed8e8df
@derhuerst
adapt tests to 94fb64d ✅
b676589
@derhuerst
leg.id -> leg.tripId 💥
7f8b3b4
@derhuerst
adapt docs & examples to 6bc4755 📝
e2ae7f6
@derhuerst
tests: trip validator ✅
e277b74
@derhuerst
adapt tests to 6bc4755 ✅
1f42bab
@derhuerst
locations: default opt.results to 5 💥 📝
2dd1022
@derhuerst
parseLine: remove line.class & line.productCode 💥
3fb746b
@derhuerst
remove line.class & line.productCode from docs 📝
fe2f2ef 
adapting to 8dd4ef5
@derhuerst
[todo] changelog & "migration to 4" guide 📝, 4.0.0
9fe6bd6 
[ci skip]
@ghost
Copy link
Author

ghost commented Jan 7, 2019

rebased it for current 4 branch

@derhuerst derhuerst added the breaking breaking change label Jan 9, 2019
derhuerst
derhuerst reviewed Jan 9, 2019
View reviewed changes
@derhuerst
Copy link
Member

Thanks!

fix(journeys): return stringifyable object
929170b 
Previously, an array with additional attributes `earlierRef` and `laterRef` was returned. When stringified, the attributes were missing.
@ghost
Copy link
Author

ghost commented Jan 15, 2019

what's blocking this?

@derhuerst
Copy link
Member

what's blocking this?

Nothing. I'm currently on vacation. Let's see if I manage to pull this into 4 now.

@derhuerst derhuerst force-pushed the 4 branch 4 times, most recently from e9c9ab7 to a745b89 Compare January 16, 2019 15:28
@derhuerst
Copy link
Member

Thanks! Cherry-picked, slightly modified and pushed the changes as eb68321. Also added c0cf1cd & da27bbd.

@derhuerst derhuerst closed this Jan 16, 2019
@derhuerst derhuerst mentioned this pull request Jan 23, 2019
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking breaking change
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@derhuerst