Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u prefix in error messages in Python 2 when schema is loaded from file #751

Closed
abitrolly opened this issue Oct 10, 2020 · 2 comments
Closed

Comments

@abitrolly
Copy link

Given.

$  cat schema.json
{
    "type" : "object",
    "properties" : {
        "price" : {"type" : "number"},
        "name" : {"type" : "string"}
    }
}

$ cat sample.json
{"name" : "Eggs", "price" : "xxx"}

When running with Python 2, the error message prefixes each field with u.

$ jsonschema -i sample.json schema.json 
xxx: u'xxx' is not of type u'number'

For Python 3 there is no u prefix.

xxx: 'xxx' is not of type 'number'

That's was the reason of tests failure in Poetry - https://github.com/python-poetry/poetry-core/pull/99/checks?check_run_id=1236052810

@Julian
Copy link
Member

Julian commented Oct 10, 2020

Hi. This is expected behavior, at least until #712, though even afterwards, the exact content of the CLI's output is not part of jsonschema's public API, so this may break at any time if you're doing some sort of exact matching. #673 would likely fix that if you want specifically to test through the CLI, though I haven't looked carefully at what that PR is doing, so not sure I can make a concrete recommendation.

But yeah if you're just asking about the output being valid JSON instead of a Python repr, #712 should fix that.

@Julian Julian closed this as completed Oct 10, 2020
@abitrolly
Copy link
Author

The problem is here.

https://github.com/Julian/jsonschema/blob/e48d56cbd2b6c25d4a9483f53f79ec537b9a4a34/jsonschema/_utils.py#L131

It could at least use %s specifier for string parameters. The problems repeats for any json loaded from file, which is passed to API.

abitrolly added a commit to abitrolly/poetry-core that referenced this issue Oct 10, 2020
abitrolly added a commit to abitrolly/poetry-core that referenced this issue Sep 27, 2021
Julian added a commit that referenced this issue Jan 31, 2025
4ba013d5 Merge pull request #747 from santhosh-tekuri/duration
aa500e80 Merge pull request #749 from json-schema-org/gregsdennis/json-everything-update
eb8ce976 Merge pull request #757 from ajevans99/main
dcdae5c0 Merge pull request #758 from sirosen/hostname-format-check-empty-string
db21d21b Merge branch 'main' into hostname-format-check-empty-string
3fd78f04 Merge pull request #1 from ajevans99/swift-json-schema
3cada3a9 Update README.md
82a07749 Merge pull request #753 from json-schema-org/ether/fix-draft-locations
a66d23d4  move draft-specific files to the dedicated dir for its draft
8ef15501 Merge pull request #751 from big-andy-coates/format_tests_under_format
fe1b1392 All format test cases should be under the `format` directory.
b1ee90f6 json-everything moved to an org
c00a3f94 test: duration format must start with P
9fc880bf Merge pull request #740 from notEthan/format-pattern-control-char
cbd48ea5 Simplify test of \a regex character to test directly against `pattern` schema
d6f1010a Merge pull request #746 from json-schema-org/annotations
4aec22c1 Revert the changes to additionalProperties.json.
2dc10671 Move the workflow step title.
d9ce71ac May as well also show quotes in the annotation.
1b719a84 Pick the line after the description when attaching spec annotations.
08105151 Markdown is apparently not (yet?) supported in annotations.
81645773 Tidy up the specification annotator a bit.
38628b79 Make the spec URLs structure a bit easier for internal use.
4ebbeaf4 Merge branch 'Era-cell/main'
e4bd7554 dumbness2 corrected
d8ade402 inside run
57c7c869 changed install location
11f8e511 Added installing command in workflow
f2766616 template library, url loads changes
c2badb12 Merge pull request #734 from OptimumCode/idn-hostname-arabic-indic-mixed
dd9599a5 Merge branch 'main' of github.com:json-schema-org/JSON-Schema-Test-Suite
5b393436 add pr dependencies action
3a509007 Clear existin annotations on same PR
23674123 Cases for rfc and iso written separately
0b780b2c Corected yaml format
2b1ffb74 Best practices followed with optimized code
e88a2da6 Works for all OS
7b40efe4 Base path for neighbouring file?
564e6957 Walking through all leaf files
7b84fb44 Merge branch 'main' of https://github.com/Era-cell/JSON-Schema-Test-Suite
891d0265 First workflow2
1c175195 regex correction
96f7683a Final correction2 - file names beautufied
5f050a07 Final correction1
77527b63 Stupidity corrected
eb8fd760 Branch name specified
540a269b Log2
f29d090a Wrong location sepcification
582e12be logging logs check
df3bdecc path corrected
c6b937ca Reading all jsons and spec urls added
cbdd1755 change day2
79dc92f1 TOKEN
ce52852d Python file location changed
3558c2c6 Fake add to tests
eecc7b7a Merge branch 'main' of https://github.com/Era-cell/JSON-Schema-Test-Suite
810d148a First workflow2
4eac02c7 First workflow
40bcb8b3 Corrected replaced unevaluated with additoinalProperties
4ae14268 Add valid first character to avoid Bidi rule violation
202d5625 test: hostname format check fails on empty string

git-subtree-dir: json
git-subtree-split: 4ba013d58e747ecaf48c8bb7cf248cb0d564afbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants