perf: Cache subschemas #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #896 +/- ##
=======================================
Coverage 98.26% 98.27%
=======================================
Files 20 20
Lines 3170 3181 +11
Branches 426 430 +4
=======================================
+ Hits 3115 3126 +11
Misses 44 44
Partials 11 11
Continue to review full report at Codecov.
|
|
Wonderful, thanks again, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #894. This patch introduces a cache for subschemas-related keywords, which reduces the number of calls to the search routine. All subschemas-related keywords are searched in one pass and then stored in a cached dict. With the OP from #893 it reduces the total number of function calls from 61512655 to 56438634 (~9%). The number of calls to the search routine is reduced 5x (from 1090000 to 218000).
I'd be happy to know what do you think :)