Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the django_template benchmark #329

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Fix the django_template benchmark #329

merged 2 commits into from
Mar 5, 2024

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Mar 5, 2024

This is broken by the removal of the cgi module in Python 3.13. This adds the legacy-cgi PyPI library as a dependency as a workaround.

@mdboom mdboom mentioned this pull request Mar 5, 2024
Open
9 tasks
@mdboom mdboom requested a review from ericsnowcurrently March 5, 2024 17:50
ericsnowcurrently
ericsnowcurrently approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsnowcurrently ericsnowcurrently merged commit 1676592 into python:main Mar 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdboom @ericsnowcurrently