fixed permissions errors when applying multiple namespaces #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakefhyde
approved these changes
Nov 9, 2021
snasovich
reviewed
Nov 10, 2021
paynejacob
force-pushed
the
issue-34712
branch
from
5e9f7df to
5357c5b
Compare
jakefhyde
approved these changes
Nov 10, 2021
cmurphy
approved these changes
Nov 10, 2021
snasovich
requested changes
Nov 10, 2021
paynejacob
force-pushed
the
issue-34712
branch
from
5357c5b to
bb12631
Compare
jakefhyde
approved these changes
Nov 10, 2021
snasovich
requested changes
Nov 10, 2021
pkg/apply/desiredset_process_test.go
Outdated
| assert.NoError(t, err) | ||
| } | ||
|
|
||
| if tt.expectedCalls > 0 { |
There was a problem hiding this comment.
Should be >= to fully validate the first test case.
paynejacob
force-pushed
the
issue-34712
branch
from
bb12631 to
e296697
Compare
cmurphy
approved these changes
Nov 11, 2021
kinarashah
approved these changes
Nov 11, 2021
This was referenced Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rancher/rancher#34712
Problem
When users try to modify resources in multiple namespaces wrangler attempts to list them across all namespaces. Most users do not have permission to list resources across all namespaces and an error is returned.
Solution
When applying resources gather what namespaces will be affected make multiple searches across the specified namespaces.
Testing
I tested this and confirmed users will still see permission errors if they attempt to create a resource in a namespace that they do not have access to. I also tested creating resources that are not namespaced with a user that has access to them.