Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the go.mod to include indirect deps #211

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

mattfarina
Copy link
Contributor

When running go test there is a message about dependencies and to
run go mod tidy. This change does just that.

When running go test there is a message about dependencies and to
run go mod tidy. This change does just that.

Signed-off-by: Matt Farina <[email protected]>
@mattfarina
Copy link
Contributor Author

Note, with Go 1.17 if you try to run Go tests there's a message that says...

go: updates to go.mod needed; to update it:
	go mod tidy

The updates to the go.mod have been tested to work with both Go 1.17 and 1.18.

@cbron cbron requested a review from cmurphy June 22, 2022 19:39
Copy link
Contributor

@cbron cbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, it's already on 1.17

@cmurphy cmurphy merged commit cc833dd into rancher:master Jun 23, 2022
@mattfarina mattfarina deleted the update-mod branch June 24, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants