Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds webhook documentation and makes Request fully public. #226

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

KevinJoiner
Copy link
Contributor

To create effective tests in supported projects, callers need
the ability to create a valid webhook.Request which involves
setting the ObjectType.

Copy link
Contributor

@MbolotSuse MbolotSuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There appears to be no changes to function signatures, and you seem to have gotten all 4 uses of objTemplate.

Copy link
Contributor

@rmweir rmweir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

To create effective tests in supported projects callers need
the ability to create a valid webhook.Request which involves
setting the ObjectType.
@rmweir rmweir merged commit 45a1796 into rancher:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants