Removes git pkg. #289
Merged
Removes git pkg. #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Totally fine to go into master. More of a note that we have to be mindful that rancher properly replaces this before it updates to a version that contains this change. This will need to go in a new minor version or bundled with one that hasn't been tagged yet. |
rmweir
approved these changes
Mar 29, 2023
manno
approved these changes
Apr 13, 2023
|
@rmweir or @mattfarina, You should be good to merge this now since it is out of both Rancher and Fleet. |
mattfarina
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #249
Remove the git package for wrangler 2.0