Crd generation #310
Merged
Crd generation #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinJoiner
force-pushed
the
crd-generation
branch
from
484d1ca to
08b9e62
Compare
Closed
KevinJoiner
force-pushed
the
crd-generation
branch
3 times, most recently
from
3c023ff to
4e2beab
Compare
JonCrowther
reviewed
Jun 30, 2023
KevinJoiner
force-pushed
the
crd-generation
branch
from
4e2beab to
380504e
Compare
maxsokolovsky
suggested changes
Jun 30, 2023
KevinJoiner
force-pushed
the
crd-generation
branch
2 times, most recently
from
8a28b4d to
85f6386
Compare
JonCrowther
approved these changes
Jun 30, 2023
maxsokolovsky
approved these changes
Jul 3, 2023
KevinJoiner
force-pushed
the
crd-generation
branch
from
85f6386 to
aec16a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue rancher/rancher#39335
These updates are to support the creation of CRDs from API structs instead of our custom CRD defs which we will no longer need to maintain.
Commit 1
The first commit adds the ability to decode a YAML document into an object with JSON decoding. This is needed so we do not have to work with unstructered.Unstuctered Objects and map decoding.
Commit 2
Adds a new BatchCreate that creates CRDs from the apis structs. This is needed to support the new CRD generation in Rancher, which no longer use wrangler crd.CRD