-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update client-go to 0.28 and update resource lease lock #315
Conversation
Signed-off-by: galal-hussein <[email protected]>
5e65167
to
2880958
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞🏻
FYI this is a blocker for K3s and RKE2 1.28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ConfigMapsLeasesResourceLock
was causing a bug in my dev environment.
@cbron this is something we need to get RKE2/K3s 1.28.0 out, should we be merging this into master or would you prefer we create a branch or use |
This should go into master, and anything that needs to remain on 1.27 and earlier can use a branch. Unfortunately this repo now has two branching strategies - one that follows the tag structure for this repo, and another that follows rancher release versions. That should probably be addressed before any further branching occurs. |
@brandond we're not using two branching strategies. You can disregard the release/v2.x branches. Branching strategy is described in the README:
|
Merging and this will go into 2.1 |
@rmweir can we get rid of the old release/v2.x branches then? Both from here and from rancher/lasso? |
Kubernetes has removed support for ConfigMapsLeasesResourceLock in v1.28 and moved to LeasesResourceLock kubernetes/kubernetes#117558