[v1.1] Use indexer when listing cached types by hash #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruiz14
changed the title
This was referenced Oct 16, 2023
aruiz14
added a commit
to aruiz14/wrangler
that referenced
this pull request
Nov 8, 2023
aruiz14
force-pushed
the
v1.1.1-SURE-6990
branch
from
7e3af26 to
1f72e7e
Compare
|
Updated after #326 has been merged. |
|
I needed this change in |
|
CI is consistently failing but it's unrelated to my changes. I've opened #352 to address it |
moio
approved these changes
Jan 4, 2024
KevinJoiner
approved these changes
Jan 9, 2024
aruiz14
force-pushed
the
v1.1.1-SURE-6990
branch
from
1f72e7e to
fc4d13b
Compare
mattfarina
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to rancher/fleet#1842
Backport of #326 (cherry-pick + only adapting the correct import paths). That pull request was in fact originally forward-ported from v1, as that is what Fleet 0.7 and Fleet 0.8 uses. This makes this patch the closest to what was already tested by some users on their testing and production setups (using a debug build).
In other words, this backport (and subsequent new v1 release) is necessary in order to use this change on Fleet, since the current release branches still use wrangler/v1, and upgrading to v2 is not feasible.