[v1.1] Allow GeneratingHandlers to skip Apply if resource version didn't change #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I needed this change in |
|
CI is consistently failing but it's unrelated to my changes. I've opened #352 to address it |
moio
approved these changes
Jan 4, 2024
KevinJoiner
approved these changes
Jan 8, 2024
…nge (rancher#341) * Allow GeneratingHandlers to skip Apply if resource version didn't change * Run go generate * Add call count to FakeApply * Add test for UniqueApplyForResourceVersion * Simplify error handling Co-authored-by: Kevin Joiner <[email protected]> * Make generated code more readable Co-authored-by: Kevin Joiner <[email protected]> * Rename constant * Rename seenResourceVersion to storeResourceVersion * go generate * Add comments to code generator * Run go generate * Upgrade golangci-lint GitHub action, since it always fails now --------- Co-authored-by: Kevin Joiner <[email protected]>
aruiz14
force-pushed
the
v1-generating-handlers-unique-apply
branch
from
71dd4a6 to
5e12992
Compare
mattfarina
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #341. Note that this pull request was originally forward-ported from v1, as that is what Fleet 0.7 and Fleet 0.8 uses. This makes this patch the closest to what was already tested by some users on their testing and production setups (using a debug build). In other words, this backport (and subsequent new v1 release) is necessary in order to use this change on Fleet, since the current release branches still use wrangler/v1, and upgrading to v2 is not feasible.
Besides updating the import paths, the only change from the original PR is in the test code:
Since the
pkg/generic/fakedoes not exist inv1(used in tests), I had to replace it by using a mock