Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for OnRemove #473

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Add unit tests for OnRemove #473

merged 4 commits into from
Jan 8, 2025

Conversation

aruiz14
Copy link
Contributor

@aruiz14 aruiz14 commented Sep 11, 2024

Extracted from: #472

@aruiz14 aruiz14 requested a review from a team as a code owner September 11, 2024 14:40
ericpromislow
ericpromislow requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this should be a PR against main now.

@aruiz14 aruiz14 changed the base branch from master to main December 2, 2024 08:28
@aruiz14 aruiz14 requested a review from ericpromislow December 2, 2024 08:28
ericpromislow
ericpromislow requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the code I mentioned was more complex at some point and no longer needs the temporary variables.

ericpromislow
ericpromislow approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the explanation I'm fine either way

@crobby crobby merged commit 8b77677 into rancher:main Jan 8, 2025
@aruiz14 aruiz14 deleted the on-remove-tests branch January 8, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpromislow ericpromislow ericpromislow approved these changes

@moio moio moio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aruiz14 @ericpromislow @moio @crobby