Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#47207 - Updated to go v1.23 and Changed Deepcopy to use gengo/v2 #491

Closed
wants to merge 1 commit into from
Closed

#47207 - Updated to go v1.23 and Changed Deepcopy to use gengo/v2 #491

wants to merge 1 commit into from

Conversation

gehrkefc
Copy link
Contributor

@gehrkefc gehrkefc commented Dec 2, 2024

No description provided.

@gehrkefc gehrkefc marked this pull request as ready for review December 9, 2024 16:56
@gehrkefc gehrkefc requested a review from a team as a code owner December 9, 2024 16:56
@brandond
Copy link
Member

brandond commented Dec 20, 2024 •
edited
Loading

  1. We need this merged for k3s and rke2 1.32.
  2. Upstream made a mess of gengo; it no longer prunes imports but will instead helpfully gofmt your whole project when you run it. Discussion at: Performance: Use FormatOnly on imports kubernetes/gengo#277 (comment) and I have a fork at https://github.com/brandond/gengo with the affected code reverted. We may need to cary this fork in Rancher if upstream does not revert that change or at least make the behavior configurable.

This was referenced Dec 20, 2024
Merged
Merged
@gehrkefc
Copy link
Contributor Author

This work was moved to #492

@gehrkefc gehrkefc closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gehrkefc @brandond