Adjust go.mod values for go/toolchain #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brandond Added you as reviewer since you needed k8s 1.32 support / go 1.23 support earlier. This shouldn't impact you but added you as reviewer just in case. We'll publish another RC after this gets merged. |
tomleb
approved these changes
Jan 13, 2025
brandond
approved these changes
Jan 14, 2025
| go 1.23.3 | ||
| go 1.23.0 | ||
|
|
||
| toolchain go1.23.4 |
There was a problem hiding this comment.
This should be fine... we're on toolchain 1.23.3 for 1.32 at the moment but I suspect the next upstream release will bump that.
On the distros side we always use the same toolchain version as upstream, for any given patch release of Kubernetes:
https://github.com/kubernetes/kubernetes/blob/v1.32.0/build/dependencies.yaml#L118-L119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating BRO for 1.32, I found that the current config caused the CI to be brittle as it required a specific GO 1.23 release. Specifically the error I was encountering is:
This change should allow for
1.23.2(and older 1.23) to work without errors.