Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix restore BUG "RuntimeError: Expected scalars to be on CPU, got cud… #50983

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a416297338
Copy link

Why are these changes needed?

When performing a restore, the error RuntimeError: Expected scalars to be on CPU, got cuda:0 instead occurs, similar to the situation in #34159. However, in the older version, the modification was made in the policy, while in the newer version, it needs to be adjusted in torch_learner.

Related issue number

Similar to #34159

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@a416297338
Copy link
Author

@sven1977 thanks for you reivew

@jcotant1 jcotant1 added the rllib RLlib related issues label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rllib RLlib related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants