Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined date and time picker from react-native core #2

Merged
merged 78 commits into from
May 20, 2019

Conversation

Swaagie
Copy link
Collaborator

@Swaagie Swaagie commented May 17, 2019

Includes all work as described in react-native-community/discussions-and-proposals#85

What needs to be done before this work is finalized (could be separate PRs)

  • README.md docs
  • License decision (especially files from core with license comments)
  • move detox tests from core to this module
  • rename this repo to include the timepicker part?
  • profit?

Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's put this into master and continue to work from there.

@cpojer cpojer merged commit 8b77bae into react-native-datetimepicker:master May 20, 2019
Saadnajmi added a commit to Saadnajmi/datetimepicker that referenced this pull request Apr 22, 2024
^ This is the 1st commit message:

Update RNTA to 0.73

^ The commit message react-native-datetimepicker#2 will be skipped:

^ update RNTA
@Saadnajmi Saadnajmi mentioned this pull request Apr 23, 2024
5 tasks
vonovak added a commit that referenced this pull request Apr 24, 2024
* ^ This is a combination of 2 commits.
^ This is the 1st commit message:

Update RNTA to 0.73

^ The commit message #2 will be skipped:

^ update RNTA

* Try remove test butler

* Remove E2E tests for Android new arch

* Pick up main's version of ComponentDescriptor

* Update react-native-localize and locks

* Undo comment out test-butler

* Update package.json

Co-authored-by: Vojtech Novak <[email protected]>

* Update package.json

Co-authored-by: Vojtech Novak <[email protected]>

* Update package.json

Co-authored-by: Vojtech Novak <[email protected]>

* Update package.json

* Update lock

---------

Co-authored-by: Vojtech Novak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants