Sorted the list of plugins to enable deterministic loading of plugins #519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
During plugin discovery the list of found plugins is sorted to enable deterministic loading of plugins
⚡️ What's your motivation?
As described in Ideas #502 the problem is that the plugins are discovered by querying files in directories. This behavior is different depending on the underlying filesystem, means:
Window/NFTS: alphanumerical
Linux/ext: "inode" order
This leads to the situation that the loading is different when you locally test with Windows and on the pipeline the tests are running on a linux agent.
This is per se a bit inconsistent, but for us it is a problem as we have a plugin which is overwriting the tracing. We enforce by the plugin-name that our plugin is loaded last, which now only works with NTFS.
🏷️ What kind of change is this?
The list of plugins which is given back is sorted alphabetical
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.