Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#562: Add accessible reorder option in column menu #983

Closed
wants to merge 2 commits into from

Conversation

iamanishroy
Copy link
Member

#562: Add accessible reorder option in column menu.

Worked on this improvement.

I started by creating a new file ManageColumns.tsx and keeping HiddenFields.tsx as the base.

I have used react-beautiful-dnd as recommended.
Dragging will be disabled when the search text field is not empty.

Note: HiddenFields.tsx is still there for reference.

image

@vercel
Copy link

vercel bot commented Nov 24, 2022

@iamanishroy is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Nov 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rowy-os ❌ Failed (Inspect) Nov 25, 2022 at 6:46AM (UTC)

@iamanishroy
Copy link
Member Author

Hi @notsidney ,
Do I need to make any changes?

@shamsmosowi
Copy link
Member

shamsmosowi commented Nov 25, 2022

Hi @iamanishroy,
I tried it, the ordering works great!
however i had few issues:

  • the ordering feature is not disabled when the search filter is applied.
  • hiding columns is not reflected in the table unless page refresh made.
  • the goal wasn't to create a new menu, it was just to add reordering feature to the same menu, no need to change anything to the appearance of button
    Note: we made some changes recently , please update your fork to be upto date dev or rc branches
    Thanks!

@iamanishroy
Copy link
Member Author

iamanishroy commented Nov 25, 2022

New PR created #984 because of some branch related issue.
Sorry for the inconvenience.

@iamanishroy iamanishroy deleted the anishroy branch January 2, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants