Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cygwin support #774

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Berrysoft
Copy link

Most changes ported from Ookiineko.

Co-authored-by: Ookiineko <[email protected]>
@Berrysoft
Copy link
Author

Do I have to add cfg-check for this new target?

@tgross35
Copy link
Contributor

The failing job has a pinned rustc version due to a bug in the latest LLVM upgrade, but that should be resolved in a soonish nightly.

Just to confirm, cygwin doesn't support weak linking?

@Berrysoft
Copy link
Author

No, it doesn't.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but blocked on rust-lang/rust#137661 and the current builtins sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants