Check built-in operator obligation before the method's WF obligations so as to not incompletely guide inference #137811
+54
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so as to not incompletely guide inference
rustbot
added
S-waiting-on-review
Which would fix #137812. |
|
honestly E0284 kinda sucks lol, it's an error code for when a projection is ambiguous but when is a projection ever ambiguous without the corresponding trait goal being ambiguous? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137781
See the test description. Let me know if you want a more detailed step by step explanation for why this is failing.
We could alternatively fix this by trying to make
Sizedobligation checking less incomplete in the old solver... but that seems like a much larger change.r? lcnr