Prevent Websocket send from hanging if connection fails. #280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have just found out that the following code hangs if no server is running on port 9321:
this is because if the server is not running the
open_callback
is not called and thewaker
is not waked causingpoll_ready
to always returnPending
.This PR adds a
wake()
call on theerror_callback
so thatpoll_ready
will move toReady
also if an error occurs.