-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update meson and meson-python to the latest versions, 1.7.0 and 0.7.1 #39492
Conversation
Documentation preview for this PR (built with commit 4b82be4; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I would prefer if someone actually using sage-the-distro tests this.
ping? |
It seems that we need CI macOS incremental / minimal | standard... |
what? this PR unblocks cysignals update on your favourite OS! |
@tobiasdiez prefers that "someone actually using sage-the-distro tests this." As you say, macOS is the main platform, for which this PR should be tested. I noticed that among the Checks, there is no "CI macOS incremental" workflow, which would test the PR branch for sage-the-distribution on macOS, instead of "someone". As we don't have such workflow, I am running the test on my own machine. Meanwhile I wrote the comment. |
Uh, I see the comment as a disjoint thought at most i.e. "hm, maybe this thing would be useful to prevent issues like this?" instead of anything specifically have to do with this pull request i.e. it's not "we need this or I'll dispute this pull request". Let's let it rest. Anyway, on the technical issue side: Isn't that pretty much what vbraun is doing, except it's done before a release instead of after? And aren't the minimal/standard/whatever thing only run after a release instead of on each pull request anyway? (though I don't really understand what exactly is being done apart from "a lot of testing before release") [edit: okay looks like sometimes the checks for CI Linux is ran e.g. on this pull request. I guess there's a button somewhere to trigger the run.] |
Off-topic:
Me too. On the other hand, portability CI (CI Linux, etc.) implemented by github actions is documented and used by developers.
There is no "button". It is automatically triggered when there are changes in In #39009, I added a "button" (workflow-dispatch) to run "CI Linux" for selected platforms. |
On the present PR branch, sage built successfully on my macOS machine. There are two doctest failures
Maybe unrelated. On the other hand, "./configure" said
Hence I did not actually build sage with the upgraded "meson" package! So I ran
We could save developer time if there were "CI macOS incremental / minimal | standard"... |
Sage built well again, and the same doctests failed. I now leave review to @tobiasdiez. |
Seems like bad times for sage-the-distro if people using it are not even willing to review package upgrade PRs. |
even more time would be saved if meson were to be required to come from the system, full stop, no gazzillion cases to check. |
Off-topic:
That is true if the "people" is only me, and I refused to spend time to check the PR branch on my own machine after you paused reviewing this PR hoping someone to check the sage-the-distro part. |
I tested on top of #39571 and using |
Meson update is needed to deal with the issue found on #38749
A straightforward update. This will fix #39490
In particular, building of the latest cysignals on macOS might need this.
📝 Checklist
⌛ Dependencies