Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(errors): handle instance unknown resource #374

Merged
merged 3 commits into from
Apr 14, 2020
Merged

feat(errors): handle instance unknown resource #374

merged 3 commits into from
Apr 14, 2020

Conversation

kindermoumoute
Copy link
Contributor

No description provided.

golangcibot
golangcibot reviewed Apr 14, 2020
View reviewed changes
Sh4d1
Sh4d1 previously approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@Sh4d1 Sh4d1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

golangcibot
golangcibot reviewed Apr 14, 2020
View reviewed changes
golangcibot
golangcibot reviewed Apr 14, 2020
View reviewed changes
@kindermoumoute kindermoumoute force-pushed the handle-not-found-non-std-err branch from 7cff4ed to e773f48 Compare April 14, 2020 14:36
Sh4d1
Sh4d1 approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@Sh4d1 Sh4d1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kindermoumoute kindermoumoute merged commit 5ce7c5f into scaleway:master Apr 14, 2020
@kindermoumoute kindermoumoute deleted the handle-not-found-non-std-err branch April 14, 2020 14:48
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@Sh4d1 Sh4d1 Sh4d1 approved these changes

Assignees
No one assigned
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kindermoumoute @Sh4d1 @golangcibot @remyleone