feat(vpcgw): add support for type upgrade (#2666)

* feat(vpcgw): add support for type upgrade

* update cassettes

---------

Co-authored-by: Rémy Léone <[email protected]>

Author: yfodil

internal/services/vpcgw/public_gateway.go

@@ -42,7 +42,6 @@ func ResourcePublicGateway() *schema.Resource {
 			"type": {
 				Type:             schema.TypeString,
 				Required:         true,
-				ForceNew:         true,
 				Description:      "gateway type",
 				DiffSuppressFunc: dsf.IgnoreCase,
 			},
@@ -229,6 +228,16 @@ func ResourceVPCPublicGatewayUpdate(ctx context.Context, d *schema.ResourceData,
 		updateRequest.UpstreamDNSServers = types.ExpandUpdatedStringsPtr(d.Get("upstream_dns_servers"))
 	}
 
+	_, err = api.UpdateGateway(updateRequest, scw.WithContext(ctx))
+	if err != nil {
+		return diag.FromErr(err)
+	}
+
+	_, err = waitForVPCPublicGateway(ctx, api, zone, id, d.Timeout(schema.TimeoutUpdate))
+	if err != nil {
+		return diag.FromErr(err)
+	}
+
 	if d.HasChange("refresh_ssh_keys") {
 		_, err := api.RefreshSSHKeys(&vpcgw.RefreshSSHKeysRequest{
 			Zone:      gateway.Zone,
@@ -244,9 +253,15 @@ func ResourceVPCPublicGatewayUpdate(ctx context.Context, d *schema.ResourceData,
 		return diag.FromErr(err)
 	}
 
-	_, err = api.UpdateGateway(updateRequest, scw.WithContext(ctx))
-	if err != nil {
-		return diag.FromErr(err)
+	if d.HasChange("type") {
+		_, err := api.UpgradeGateway(&vpcgw.UpgradeGatewayRequest{
+			Zone:      gateway.Zone,
+			GatewayID: gateway.ID,
+			Type:      types.ExpandUpdatedStringPtr(d.Get("type")),
+		}, scw.WithContext(ctx))
+		if err != nil {
+			return diag.FromErr(err)
+		}
 	}
 
 	_, err = waitForVPCPublicGateway(ctx, api, zone, id, d.Timeout(schema.TimeoutUpdate))

internal/services/vpcgw/public_gateway_test.go

@@ -174,6 +174,43 @@ func TestAccVPCPublicGateway_AttachToIP(t *testing.T) {
 	})
 }
 
+func TestAccVPCPublicGateway_Upgrade(t *testing.T) {
+	tt := acctest.NewTestTools(t)
+	defer tt.Cleanup()
+	publicGatewayName := "public-gateway-upgrade-test"
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:          func() { acctest.PreCheck(t) },
+		ProviderFactories: tt.ProviderFactories,
+		CheckDestroy:      vpcgwchecks.IsGatewayDestroyed(tt),
+		Steps: []resource.TestStep{
+			{
+				Config: fmt.Sprintf(`
+					resource scaleway_vpc_public_gateway main {
+						name = "%s"
+						type = "VPC-GW-S"
+					}
+				`, publicGatewayName),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckVPCPublicGatewayExists(tt, "scaleway_vpc_public_gateway.main"),
+					resource.TestCheckResourceAttr("scaleway_vpc_public_gateway.main", "type", "VPC-GW-S"),
+				),
+			},
+			{
+				Config: fmt.Sprintf(`
+					resource scaleway_vpc_public_gateway main {
+						name = "%s"
+						type = "VPC-GW-M"
+					}
+				`, publicGatewayName),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckVPCPublicGatewayExists(tt, "scaleway_vpc_public_gateway.main"),
+					resource.TestCheckResourceAttr("scaleway_vpc_public_gateway.main", "type", "VPC-GW-M"),
+				),
+			},
+		},
+	})
+}
+
 func testAccCheckVPCPublicGatewayExists(tt *acctest.TestTools, n string) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		rs, ok := s.RootModule().Resources[n]