Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vpcgw): add support for type upgrade #2666

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Jul 29, 2024

No description provided.

@yfodil yfodil added enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests labels Jul 29, 2024
@yfodil yfodil self-assigned this Jul 29, 2024
@yfodil yfodil requested a review from remyleone as a code owner July 29, 2024 15:39
@remyleone remyleone marked this pull request as draft July 30, 2024 13:21
@yfodil yfodil marked this pull request as ready for review July 30, 2024 13:44
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.02%. Comparing base (fe86049) to head (455ac12).
Report is 126 commits behind head on master.

Files Patch % Lines
internal/services/vpcgw/public_gateway.go 57.14% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2666      +/-   ##
==========================================
- Coverage   71.43%   71.02%   -0.42%     
==========================================
  Files         277      334      +57     
  Lines       35875    33485    -2390     
==========================================
- Hits        25628    23782    -1846     
+ Misses       8028     7392     -636     
- Partials     2219     2311      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Jul 30, 2024
Merged via the queue into scaleway:master with commit 2556547 Jul 30, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants