fix(instance): add missing zone in a volume request (#820)

Author: remyleone

scaleway/resource_instance_server.go

@@ -297,6 +297,7 @@ func resourceScalewayInstanceServerCreate(ctx context.Context, d *schema.Resourc
 		for i, volumeID := range raw.([]interface{}) {
 			// We have to get the volume to know whether it is a local or a block volume
 			vol, err := instanceAPI.GetVolume(&instance.GetVolumeRequest{
+				Zone:     zone,
 				VolumeID: expandZonedID(volumeID).ID,
 			})
 			if err != nil {

scaleway/resource_instance_server_test.go

@@ -882,3 +882,39 @@ func TestAccScalewayInstanceServer_Enterprise(t *testing.T) {
 		},
 	})
 }
+
+func TestAccScalewayInstanceServer_ServerWithBlockNonDefaultZone(t *testing.T) {
+	tt := NewTestTools(t)
+	defer tt.Cleanup()
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:          func() { testAccPreCheck(t) },
+		ProviderFactories: tt.ProviderFactories,
+		CheckDestroy:      testAccCheckScalewayInstanceServerDestroy(tt),
+		Steps: []resource.TestStep{
+			{
+				Config: `
+					resource "scaleway_instance_volume" "main" {
+						type       = "b_ssd"
+						name       = "main"
+						size_in_gb = 1
+						zone       = "nl-ams-1"
+					}
+
+					resource "scaleway_instance_server" "main" {
+						zone              = "nl-ams-1"
+						image             = "ubuntu_focal"
+						type              = "DEV1-S"
+						root_volume {
+							delete_on_termination = true
+							size_in_gb            = 20
+						}
+						additional_volume_ids = [scaleway_instance_volume.main.id]
+					}
+				`,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckScalewayInstanceServerExists(tt, "scaleway_instance_server.main"),
+				),
+			},
+		},
+	})
+}