fix(vpc-dhcp-reservation): add ForceNew on mac_address field for DHCP reservation (#1274)

The update method for DHCP reservation doesn't update the mac address
(same as the api behind). Any change on this field must trigger a
replacement, not an in-place update (which won't do anything).

Co-authored-by: Rémy Léone <[email protected]>

Author: dduponchel

scaleway/resource_vpc_public_gateway_dhcp_reservation.go

@@ -41,6 +41,7 @@ func resourceScalewayVPCPublicGatewayDHCPReservation() *schema.Resource {
 			"mac_address": {
 				Type:         schema.TypeString,
 				Required:     true,
+				ForceNew:     true,
 				Description:  "The MAC address to give a static entry to.",
 				ValidateFunc: validation.IsMACAddress,
 			},