fix(vpc-dhcp-reservation): add ForceNew on mac_address field for DHCP reservation #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update method for DHCP reservation doesn't update the mac address (same as the api behind). Any change on this field must trigger a replacement, not an in-place update (which won't do anything).
remyleone
approved these changes
May 13, 2022
remyleone
changed the title
remyleone
changed the title
remyleone
added a commit
to remyleone/terraform-provider-scaleway
that referenced
this pull request
Jun 17, 2022
… reservation (scaleway#1274) The update method for DHCP reservation doesn't update the mac address (same as the api behind). Any change on this field must trigger a replacement, not an in-place update (which won't do anything). Co-authored-by: Rémy Léone <[email protected]>
remyleone
added
the
vpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update method for DHCP reservation doesn't update the mac address
(same as the api behind). Any change on this field must trigger a
replacement, not an in-place update (which won't do anything).