Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flexibleip): add support for flexible ip #1022

Merged
merged 25 commits into from
Jul 12, 2022

Conversation

remyleone
Copy link
Member

No description provided.

@remyleone remyleone marked this pull request as draft January 6, 2022 15:13
@remyleone remyleone linked an issue Mar 11, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #1022 (f1085c6) into master (229636c) will increase coverage by 0.00%.
The diff coverage is 67.98%.

@@           Coverage Diff            @@
##           master    #1022    +/-   ##
========================================
  Coverage   66.67%   66.67%            
========================================
  Files         119      122     +3     
  Lines       19173    19474   +301     
========================================
+ Hits        12783    12984   +201     
- Misses       5286     5354    +68     
- Partials     1104     1136    +32     
Impacted Files Coverage Δ
scaleway/data_source_baremetal_server.go 61.81% <25.00%> (-6.94%) ⬇️
scaleway/resource_flexible_ip.go 67.17% <67.17%> (ø)
scaleway/data_source_flexible_ip.go 69.11% <69.11%> (ø)
scaleway/helpers_flexible_ip.go 79.31% <79.31%> (ø)
scaleway/provider.go 71.05% <100.00%> (+0.21%) ⬆️
scaleway/resource_baremetal_server.go 69.91% <100.00%> (ø)
scaleway/retryable_transport.go 70.00% <0.00%> (-10.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 229636c...f1085c6. Read the comment docs.

@yfodil yfodil marked this pull request as ready for review July 1, 2022 10:03
@remyleone remyleone merged commit f9f55ab into scaleway:master Jul 12, 2022
@remyleone remyleone deleted the ip_flexible branch July 12, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for flexible IP in elastic-metal
4 participants